Implement several fixes and QoL improvements to the Data Preparation MLCube #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TS-AI-Front-End into separate-stages
…ront-End into separate-stages
…TS-AI-Front-End into separate-stages
Move model execution to subprocesses to eliminate memleak
This reverts commit 987daf1.
Wrap conflicting functions instead of stages
sarthakpati
reviewed
Dec 12, 2024
Member
sarthakpati
left a comment
sarthakpati
left a comment
There was a problem hiding this comment.
Minor comments (only white space additions)
| !*/mlcube/workspace/parameters.yaml | ||
| models | ||
| models | ||
| tmpmodel |
Member
There was a problem hiding this comment.
Suggested change
| tmpmodel | |
| tmpmodel | |
| DIFF=$(echo "$ENDTIME - $STARTTIME" | bc) | ||
| echo $DIFF | ||
|
|
||
| run_other No newline at end of file |
Member
There was a problem hiding this comment.
Suggested change
| run_other | |
| run_other | |
| DIFF=$(echo "$ENDTIME - $STARTTIME" | bc) | ||
| echo $DIFF | ||
|
|
||
| run_other No newline at end of file |
Member
There was a problem hiding this comment.
Suggested change
| run_other | |
| run_other | |
| RUN cp -r /project/tmpmodel /project/stages/data_prep_models/brain_extraction/model_0 | ||
| RUN mv /project/tmpmodel /project/stages/data_prep_models/brain_extraction/model_1 | ||
|
|
||
| ENTRYPOINT ["python", "/project/mlcube.py"] No newline at end of file |
Member
There was a problem hiding this comment.
Suggested change
| ENTRYPOINT ["python", "/project/mlcube.py"] | |
| ENTRYPOINT ["python", "/project/mlcube.py"] | |
| shutil.rmtree(tmpfolder, ignore_errors=True) | ||
|
|
||
| if __name__ == "__main__": | ||
| main() |
Member
There was a problem hiding this comment.
Please add a new line at the end for consistency.
| ) | ||
|
|
||
| if __name__ == "__main__": | ||
| main() No newline at end of file |
Member
There was a problem hiding this comment.
Suggested change
| main() | |
| main() | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
And many more changes.